fix: use changeset tag instead of publish, defer npm publishing to cargo-dist#2
fix: use changeset tag instead of publish, defer npm publishing to cargo-dist#2
Conversation
|
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request refines the publishing workflow for the Highlights
Changelog
Ignored Files
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request modifies package.json to set the private property to true. This action prevents the package from being published to the npm registry, which is consistent with the pull request's objective to delegate publishing to cargo-dist. The change is self-contained and I have no further feedback.
jpoehnelt
force-pushed
the
fix/publishing
branch
from
3116bfe to
9e9e566
Compare
jpoehnelt
force-pushed
the
fix/publishing
branch
from
d1dd1b6 to
5afdedd
Compare
…rgo-dist (googleworkspace#2) * fix: use changeset tag instead of publish, defer npm publishing to cargo-dist * fix: quote label names containing colons in labeler.yml * chore: delete labeler
1 participant
Problem
The
release-changesets.ymlworkflow usespnpm changeset publishwhich attempts to publish@googleworkspace/clidirectly to npm when no pending changesets exist. This fails withENEEDAUTHbecause npm publishing should be handled by cargo-dist'srelease.yml, not by changesets.Additionally,
.github/labeler.ymlhas a YAML parse error — label names containing colons need to be quoted.Fix
Publishing
Separate concerns between the two release workflows:
release-changesets.yml) — version management only. Usespnpm changeset tagto bump versions and push git tags.release.yml) — binary distribution + npm publishing. Triggered by the git tag pushed by changesets.Labeler
Quote all label names containing colons in
labeler.yml.Changes
release-changesets.yml:pnpm changeset publish→pnpm changeset tag, removedid-tokenpermission andNPM_TOKENenv varpackage.json: added"private": trueto prevent accidental direct npm publishinglabeler.yml: quoted label names containing colons (e.g.area: schema→"area: schema")